Skip to content
This repository was archived by the owner on Aug 29, 2026. It is now read-only.

Use random IDs for filters and headers - #21

Open
iccccccccccccc wants to merge 1 commit into
Blackilykat:masterfrom
iccccccccccccc:fix-random-filter-header-ids
Open

Use random IDs for filters and headers#21
iccccccccccccc wants to merge 1 commit into
Blackilykat:masterfrom
iccccccccccccc:fix-random-filter-header-ids

Conversation

@iccccccccccccc

Copy link
Copy Markdown

Summary

  • Generate random positive IDs for client-side filters and headers instead of using persisted counters
  • Avoid reusing IDs that are already present locally, and for filters also avoid IDs from the last known server filter list
  • Remove the now-unused filter/header ID counters from client storage

Verification

  • gradlew.bat build --no-daemon --console=plain with JDK 25.0.3

Closes #20

@Blackilykat

Copy link
Copy Markdown
Owner

Thanks for contributing!

You wrote that to verify this PR you built the project. Does this imply you did not run the code? Did you run the server and clients to verify that the bug described in the issue is actually fixed? You should be able to see some logs containing the IDs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the way filter and header IDs are assigned is flawed

2 participants